sceNpTrophy: Fix sceNpTrophyRegisterContext for handler abortion #9586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elad335
changed the title
elad335
changed the title
|
Using recursive mutex is considered a bad practice. Did you think of better workarounds? |
|
A small hack can be made so it reruns all error checks and calls get_context_ex twice before and after first callback including the INITIALIZED check. (with unlock, callback(), relock mutex) Who knows maybe fw does something similar as well. |
|
Well, typical workflow with normal mutex is lock - update - unlock, where update doubtfully allows some arbitrary code such as a callback to execute. Something like relocking after callback seems more sound. |
|
Done. |
elad335
force-pushed
the
patch-14
branch
2 times, most recently
from
30f8af5
to
0846938
Compare
|
elad335
force-pushed
the
patch-14
branch
2 times, most recently
from
262d5c4
to
1cc8dee
Compare
Nekotekina
changed the title
|
Wait a second, this is not sceNpTrophyAbortHandle right? |
Nekotekina
changed the title
Megamouse
reviewed
Jan 12, 2021
* Implement handler abortion during context registeration. * Fixed recursive calls to sceNpTrophy functions such as by callbacks from registering context. * Turns out the reader lock for context registeration was incorrect because ctxt->tropusr and trophy directory are being modified. made it an exclusive lock after callback.
elad335
changed the title
|
this one fixed the Splinter Cell Trilogy stuck at intro |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emulation Features
Bugfixes
Fixes #9415